search

ByzantineFailure / BPM-for-Discord

BPM for Discord's Desktop App. Includes one-click installers, update notifications, and custom script support.
GNU Affero General Public License v3.0
17 stars 8 forks source link

Emote rendering often scrolls chat up #79

Open Jibodeah opened 7 years ago

Jibodeah commented 7 years ago

So normally, when you switch to a channel with no new messages in it, you'll be scrolled right down to the bottom of it. ...but if there are emotes in it when BPM renders them they take up more vertical space and so the page gets pushed down. Resulting in the chat being scrolled up. ...and the more/bigger emotes there are, the worse it gets.

I think the solution would to check if the chat is scrolled fully down before rendering, and then, if it was, rescroll it down after rendering.

It doesn't always happen in all cases though. It seems to be when the emotes are pretty far from the bottom of the chat (but still getting rendered obviously). ...I wonder if rendering from the bottom up (if that's not what it's doing already) could change anything...

ByzantineFailure commented 7 years ago

@Jibodeah I suspect this is something to do with emotes in code blocks -- I recall implementing a setting that disabled this behavior. Once I get the settings menu back and cooking again I might ask you to play with a few settings and see if you can get it to repro.

ByzantineFailure commented 7 years ago

@Jibodeah -- Settings have been fixed. Can you enable the disable emotes in code blocks setting and see if this repros for you?

Jibodeah commented 7 years ago

Setting was already enabled, still reproduces.