Font scaling and zoom level reset on Discord loading with BPM installed

[1byte2bytes]

I installed BPM to Discord Canary by modifying the script to return the path for Discord PTB to Discord Canary. Whenever I launch Discord Canary, it resets my font scaling and zoom level in the settings, despite it being remembered in the settings menu itself.

[ByzantineFailure]

I think I'd need a little bit more information on this -- is this a Discord setting that is broken?

[1byte2bytes]

It is a Discord setting, yes. I have my font scaling sliders like this. Whenever Discord reloads, the view gets reset to 100% for both settings, despite the sliders staying in the same spot as if it was working. Without BPM installed, it works just fine.

[ByzantineFailure]

That is... whacky. Okay, I'll take a look into it. Does re-moving the sliders fix the issue or is it permanently borked if BPM is installed?

[1byte2bytes]

It works if I slide the sliders down to 100% and let go of the mouse. Then move them back up to their desired spot. Discord should be updating live as the sliders slide. The settings also reset back in the same fashion any time Discord reloads, such as after an update, control+r for reloading, closing Discord entirely and reopening it, what have you.

Discord Canary downloads, if you don't have it already: https://discordapp.com/api/download/canary?platform=osx https://discordapp.com/api/download/canary?platform=win

[ByzantineFailure]

Mmmkay. I've gotta rework settings first but I'll look into this after. I suppose today is the day I bite the bullet and get the settings work done.

[1byte2bytes]

Is it possible that my hacky solution to getting BPM installed on Canary is the problem? I only changed the path in the install script, so BPM proper could very well be making it read from the other Discord install (regular Discord, not PTB or Canary) as I thought I saw in the install script.

[ByzantineFailure]

It's unlikely that changing the install paths messed with the internals. Those only affect where/how to point the installer to find the app.asar.

I suspect there's some preferences issue that's going wrong when writing and retrieving values -- maybe some overlapping key. Will have to investigate.

On Jul 23, 2017 10:27 AM, "Sydney Erickson" notifications@github.com wrote:

Is it possible that my hacky solution to getting BPM installed on Canary is the problem? I only changed the path in the install script, so BPM proper could very well be making it read from the other Discord install (regular Discord, not PTB or Canary) as I thought I saw in the install script.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ByzantineFailure/BPM-for-Discord/issues/84#issuecomment-317268581, or mute the thread https://github.com/notifications/unsubscribe-auth/AEwr6SC0T4dlsgVxdVEELXPqPsqa-Uc9ks5sQ4KBgaJpZM4OgXmZ .

[1byte2bytes]

If there is any testing or anything I could do to help, let me know!

[1byte2bytes]

I have installed the brand now 0.10.0 update to both the PTB and Canary clients. I can reproducibly trigger the issue on both. I had set the scaling settings for both clients before installing BPM.

Both tested on macOS 10.12.6 with all Discord and BPM for Discord updates applied. I can test on other operating systems if you want to.

[Jibodeah]

I've reproduced the issue on Linux (Canary client).

[1byte2bytes]

I had a try on Windows, and the release client and PTB showed this issue as well.