C-3PFLO / flow-rpg

RPG your NFT
1 stars 0 forks source link

Proper Contract #4

Closed C-3PFLO closed 1 year ago

C-3PFLO commented 1 year ago
C-3PFLO commented 1 year ago

For sample NFT contract, add a second collection.

for both, include a URL to an image of an existing NFT project, like my favorite goobs and flovatars.

C-3PFLO commented 1 year ago

image

C-3PFLO commented 1 year ago

Dropped Minter task and added this comment: https://github.com/C-3PFLO/flow-rpg/blob/b13e1729a621007b762080fcd2a1e16abd4c232b/cadence/contracts/FlowRPG.cdc#L203

    // only the owner of an nft can 'attach' something to it
    // and an attachment must be created in the statement where it is attached
    // thus we cannot use something like a minter pattern, where
    // only an admin user can mint an RPGCharacter and send it to users
    // if this were to be gated or monetized, that would have to happen
    // within this public function
    pub fun attachRPGCharacter(

to be discussed with experts, but defer from this issue

C-3PFLO commented 1 year ago

Moving Metadata.Resolver to a dedicated function and considering this good enough for now