C-Accel-CRIPT / Python-SDK

CRIPT Python SDK
MIT License
10 stars 5 forks source link

removed `get_node_by_uuid` cript.API feature #409

Closed nh916 closed 1 year ago

nh916 commented 1 year ago

Description

removed get_node_by_uuid cript.API feature. This method will be removed in later versions in favor of the single search cript.API.get_node_by_exact_match()

I thought it'd be a better idea to remove it from the SDK and not release it in this version because if users use it, and we remove it in the next version it will introduce a breaking change that will break their script and it will be a hassle, better to not introduce at all this version and work on it in the next version.

Changes

Tests

Known Issues

Notes

Checklist

trunk-io[bot] commented 1 year ago

Merging to develop in this repository is managed by Trunk.

nh916 commented 1 year ago

@InnocentBug if you can please see if you can format it with trunk as I am running trunk fmt on my system through WSL, but it is not formatting anything or finding any issues

InnocentBug commented 1 year ago

done

nh916 commented 1 year ago

done

You are the best! ✅ 🚀

nh916 commented 1 year ago

it's a shame this had to go because I worked hard on it too, but the new feature will be even better!