InnocentBug commented 11 months ago

Description

Give an option to disbale the UID use for JSON.

@bearmit

Changes

Disabling the use of UIDs, make JSON generation for graphs that contain cycles crash. This is not gracefully handled at the moment.

I am not sure it is a good idea to offer users on option that leads to ungracefully handled errors.

It would be nice to offer this option for @bearmit work. But I am scared to include it, what do you think @Ardi028 ?

[y] My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
[half] I have updated the documentation to reflect my changes.
[n] My code changes have been verified by automated tests and pass all relevant test scenarios.

trunk-io[bot] commented 11 months ago

Merging to develop in this repository is managed by Trunk.

[ ] To merge this pull request, check the box to the left or comment /trunk merge below.

bearmit commented 11 months ago

Ok, I might do this manually. I suppose I would need to disable the same way the use of EdgeUUID (line 117) too EDIT: no!!).

bearmit commented 11 months ago

@InnocentBug It worked like a charm.