search

C-Nedelcu / talk-to-chatgpt

Talk to ChatGPT AI using your voice and listen to its answers through a voice
GNU Affero General Public License v3.0
1.97k stars 330 forks source link

Sentence breaking doesn't work well with Turkish number format #118

Open cemreefe opened 1 year ago

cemreefe commented 1 year ago

In Turkish, thousands are separated with a fullstop . and fractions are separated with a comma . as opposed to many other languages that use a comma , for thousands and . for fractions. See example:

English:

The expenses came up to 1,550,309.56 TRY.

Turkish: 

Harcamalar 1.550.309,56 TL tuttu.

The sentence separation function below could be improved to take into account thse format differences.

https://github.com/C-Nedelcu/talk-to-chatgpt/blob/8865d3e957af4237fd9bb8d46a3089a8eba3c7d8/chrome-extension/content.js#L421-L455

C-Nedelcu commented 1 year ago

Thank you, this is true, numbers need to be correctly parsed.

abhisheksharma010 commented 1 year ago

Hello, I would like to work on this, can it be assigned to me