C-Nedelcu / talk-to-chatgpt

Talk to ChatGPT AI using your voice and listen to its answers through a voice
GNU Affero General Public License v3.0
1.97k stars 333 forks source link

Basic Improvements UI/ UX wanted #208

Open Chinyeins opened 1 year ago

Chinyeins commented 1 year ago

Hey, I love your extension, it is so usefull. Id like to share some improvements that might be interesting to other people using the extension. Unfortunately people that require changes, probably just fork the project and impl. the changes themselves, but I think these changes could benefit greatly in general for this project:

  1. I find the settings page is not very readable and i think the font and structure makes it hard to navigate image

    • one single set of save, cancel
    • better readability for text (change font and or make bigger)
    • seperate info from actual settings, since its confusing
    • removed background tansparency, since it reduces readability
  2. The API Key for the ElevenLabs should be hidden by default i think, since it´s a secret, I think it´s better practice to auto hide it when openeing the settings page. image

  3. depending on your setup the volume of tts can be quite loud, so a slider to change tts volume would be great image

  4. A way of replaying messages via TTS feature would be very useful, since currently after asking something, TTS will kick in and read the message generated, but cant be replayed.

  5. Technical improvements, im curious why the markup and code are mixed and most of the code is in one big god class instead of trying to split features to extra classes. Theres a lot of room for improvements on the code side by extracting the markup to seperate file and referecing in code and extracting features to dedicated files / classes. But that sprobably a big one

  6. Deactivate initialization sound after pressin start button. There should be an option to deactivate the sound in settings page, that also gets saved into settings cookie.

  7. refactoring settings cookie to make us of chromes storage api. The reason for why this could be usefull is, you could store / sync settings for this extension accross browsers. API Key should be excluded from that I think.

For some of my concerns i already impl. at least a suggestions of how it can look like: you can find it unter this PR Pull Request, suggested changes: https://github.com/C-Nedelcu/talk-to-chatgpt/pull/205

If you like to test the changes quickly, heres my fork for the changes i made so far: https://github.com/Chinyeins/talk-to-chatgpt-brainstuck

Love your work

C-Nedelcu commented 1 year ago

Hi ChinyONE,

I did notice that you made a few pull requests which is great, I haven’t had time to try them yet (I’m extremely busy at work lately) but I will soon.

I’d be happy if you would continue contributing to the project by making further changes.

I am fine with all the suggestions you have made, they would certainly be a good help all round.

This project has quite a large user base and since I don’t have enough time to maintain the project, I am sure some people are disappointed.

As for why the code is messy: it basically started out a simple proof of concept, which I extended further and further, but I never took the time to rebuild it properly, and of course it’s now a mess.

So in conclusion, if you want to become more active on this project you are more than welcome.

thanks for all this!

Clement

From: ChinyONE @.> Sent: Thursday, November 16, 2023 1:24 AM To: C-Nedelcu/talk-to-chatgpt @.> Cc: Subscribed @.***> Subject: [C-Nedelcu/talk-to-chatgpt] Basic Improvements UI/ UX wanted (Issue #208)

Hey, I love your extension, it is so usefull. Id like to share some improvements that might be interesting to other people using the extension. Unfortunately people that require changes, probably just fork the project and impl. the changes themselves, but I think these changes could benefit greatly in general for this project:

  1. I find the settings page is not very readable and i think the font and structure makes it hard to navigate
  2. The API Key for the ElevenLabs should be hidden by default i think, since it´s a secret, I think it´s better practice to auto hide it when openeing the settings page.
  3. depending on your setup the volume of tts can be quite loud, so a slider to change tts volume would be great
  4. A way of replaying messages via TTS feature would be very useful, since currently after asking something, TTS will kick in and read the message generated, but cant be replayed.
  5. Technical improvements, im curious why the markup and code are mixed and most of the code is in one big god class instead of trying to split features to extra classes. Theres a lot of room for improvements on the code side by extracting the markup to seperate file and referecing in code and extracting features to dedicated files / classes. But that sprobably a big one
  6. Deactivate initialization sound after pressin start button. There should be an option to deactivate the sound in settings page, that also gets saved into settings cookie.
  7. refactoring settings cookie to make us of chromes storage api. The reason for why this could be usefull is, you could store / sync settings for this extension accross browsers. API Key should be excluded from that I think.

For some of my concerns i already impl. at least a suggestions of how it can look like: you can find it unter this PR Pull Request, suggested changes: #205 https://github.com/C-Nedelcu/talk-to-chatgpt/pull/205

Love your work

— Reply to this email directly, view it on GitHub https://github.com/C-Nedelcu/talk-to-chatgpt/issues/208 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDX2EFRIJQ2OGVHABXOPCDYET3CTAVCNFSM6AAAAAA7M3DPFWVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TKMRRGY3TQMA . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ABDX2EAVWCJY55K4KONXZZ3YET3CTA5CNFSM6AAAAAA7M3DPFWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHN3EXRQ.gif Message ID: @. @.> >