C-RH-C / hcs-collector

GNU General Public License v3.0
2 stars 5 forks source link

Filter by tagging #9

Closed starnold-redhat closed 1 year ago

starnold-redhat commented 1 year ago

ok

waldirio commented 1 year ago

Also @starnold-redhat if the machines have no tags, and we pass the --tag=environment. Is the app handling the exception?

Thank you! Waldirio

starnold-redhat commented 1 year ago

Also @starnold-redhat if the machines have no tags, and we pass the --tag=environment. Is the app handling the exception?

Thank you! Waldirio

@waldirio I believe so. There's a couple of scenarios, one where the machine has no tags, and another where the tag is not present. I've checked the code - and it looks defensive enough.

starnold-redhat commented 1 year ago

Hi @waldirio , I', just going to optimise the tag downloading, and put in a bit more error handling.

Cheers

Steve