search

C-Sto / gosecretsdump

Dump ntds.dit really fast
GNU General Public License v3.0
366 stars 47 forks source link

History #9

Closed C-Sto closed 4 years ago

C-Sto commented 4 years ago

Add History option

C-Sto commented 4 years ago

This should close https://github.com/C-Sto/gosecretsdump/issues/8 once it's merged. Only thing left to do is performance checks.

C-Sto commented 4 years ago

Master:

❯ go test -bench . -benchtime 100x
goos: darwin
goarch: amd64
pkg: github.com/C-Sto/gosecretsdump/test/bench
BenchmarkProgram-8           100         197760348 ns/op        222588018 B/op    234725 allocs/op
PASS
ok      github.com/C-Sto/gosecretsdump/test/bench       20.307s

history:

❯ go test -bench . -benchtime 100x
goos: darwin
goarch: amd64
pkg: github.com/C-Sto/gosecretsdump/test/bench
BenchmarkProgram-8           100         196002770 ns/op        222695305 B/op    234894 allocs/op
PASS
ok      github.com/C-Sto/gosecretsdump/test/bench       19.836s

Not sure how it has better performance, presumably the test machine has other stuff going on.