C-bowman / inference-tools

Python tools for Bayesian data analysis
MIT License
28 stars 3 forks source link

Modernise setup #8

Closed ZedThree closed 3 years ago

ZedThree commented 3 years ago
shimwell commented 3 years ago

Hi Chris all these updates look great, wondering what you thought are on use a /src/inference folder instead of a /inference folder

C-bowman commented 3 years ago

Hi Jon!

I hadn't heard of putting the package in an /src/ folder, but it does seem that's how the PyPA have it in their example package.

These updates are thanks to Peter who is making improvements as part of his PlasmaFAIR project - I'll get his thoughts on it when we speak next.

ZedThree commented 3 years ago

I don't usually use a src/ directory for python projects, unless they're particularly complex, for example due to having multiple top-level modules. For something like inference-tools, I don't think there's any benefit (although also no significant cost either!)

shimwell commented 3 years ago

Nice, python publish action, I didn't know about that one. I currently do something similar but without using the pypa/gh-action-pypi-publish@release/v1. I'm learning lots for these PRs , thanks for teaching good practice.