C0D3D3V / bbb-dl

Downlaod BigBlueButton recordings. A simple scrapper for Big Blue Button lessons. Download and merge the audio and video files of a BigBlueButton conference from the conference replay url.
MIT License
65 stars 16 forks source link

Zero Division Error #46

Closed krim404 closed 9 months ago

krim404 commented 9 months ago

When i try to render some videos, a few are failed with the following message:

Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/bbb_dl/main.py", line 434, in _real_multi_capture_frames
    await gather_jobs
  File "/opt/homebrew/lib/python3.11/site-packages/bbb_dl/main.py", line 555, in capture_frames
    await self.set_view_box(page, action)
  File "/opt/homebrew/lib/python3.11/site-packages/bbb_dl/main.py", line 620, in set_view_box
    aspect_ratio = action.width / action.height
                   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~
ZeroDivisionError: float division by zero
Unexpected Error! Press Ctr+C to exit. Please try to set a low number of threads with `--max-parallel-chromes`. You can contact bbb-dl support.

sadly i cannot provide the source data, as they are confidential - but i can assist with information

C0D3D3V commented 9 months ago

I mean, treating the symptom would be very easy. And someone could just avoid the division by 0 and do a PR. But this is just the symptom, if someone has a lecture where the error happens, it would be great if you share it here.

C0D3D3V commented 9 months ago

Send it over, I can test it in my free time...

C0D3D3V commented 9 months ago

Please test version 1.0.7