search

C0D3D3V / bbb-dl

Downlaod BigBlueButton recordings. A simple scrapper for Big Blue Button lessons. Download and merge the audio and video files of a BigBlueButton conference from the conference replay url.
MIT License
67 stars 17 forks source link

Allow parametric encoder via --encoder #6

Closed SamuelePilleri closed 3 years ago

SamuelePilleri commented 3 years ago

This is useful for h264_nvenc encoders and such.

Couldn't test it since I have problems with libcairo on Windows, please test before merging.

SamuelePilleri commented 3 years ago

Ok, I managed to test with NVENC and it actually works great, went from a 5x to a solid 12x!

I also fixed a bug with files not being found in the concat phase.

I must note however that the output video doesn't play correctly on Windows and audio is muted. It plays correctly on third party software like Media Player Classic Home Cinema or VLC, but anyway I believe this is a bug and should be fixed.

SamuelePilleri commented 3 years ago

By the way, commit 8b000f7 fixes #5

federicotorrielli commented 3 years ago

Tested on Linux, it's good to go! --encoder nvenc on Arch (1660ti) brings 25x, not bad :)

C0D3D3V commented 3 years ago

Thank you very much for your PR :) I will merge it later.

I think it does not play in windows media player or similar, because the player is missing the codec. Thats normal, these old playes doesn't support complex mixed up codecs as we use them. Btw. I recomend mpv player :D

SamuelePilleri commented 3 years ago

Perhaps I should add my name to the authors list and write some documentation about the new flag. Please feel free to go for it, I will be away this weekend and probably won't have much time to look at it.

C0D3D3V commented 3 years ago

That's no problem, I'll take care of the rest. That's the least I can add to such a great contribution :)