Closed Bronnel721 closed 1 year ago
@C1710, are you procrastinating?
I looked at them yesterday and I agree with most changes. I'm not sure though about changing the color of drops (like for '๐ ') to blue. I understand why this change makes sense, but I'm not sure about it yet.
I'm not at home right now, so I can't give you more details at the moment.
If you'd like to, you, or I, can change the color back to white, but honestly, I don't know if that's a good idea.
If you'd like to, you, or I, can change the color back to white, but honestly, I don't know if that's a good idea.
If it's alright with you I would wait a bit before merging to give others a chance to add some opinions (if anyone has any).
I'll probably only include it with the 15.1 release anyway.
The disguised face is based on SpongeBob posing as Squidward, plus glasses; although when I come to think about it, I can't remember exactly, which scene it was based on. To be honest, it's not a very good design and it would make sense to adapt the Noto one instead ๐
I'll probably only include it with the 15.1 release anyway.
Are you talking about the drop color or the whole changes that I've made in general?
I'll probably only include it with the 15.1 release anyway. Are you talking about the drop color or the whole changes that I've made in general?
No, I'm talking about everything, as it's all one PR. I mean, I could try to add the other changes first (not sure right now how that would work), but i don't think I will build a new font with it directly.
I mean, I could try to add the other changes first (not sure right now how that would work), but i don't think I will build a new font with it directly.
Then how will you do it? Also, did you post the same comment twice?
I mean, I could try to add the other changes first (not sure right now how that would work), but i don't think I will build a new font with it directly.
I mean, I'll rebuild the font only with the next release or so.
Then how will you do it? Also, did you post the same comment twice?
The mobile internet connection in this train is pretty bad, so probably yes ๐
I mean, I'll rebuild the font only with the next release or so.
So you are saying that in releases after that, you won't use the ones that I designed?
I mean, I'll rebuild the font only with the next release or so.
So you are saying that in releases after that, you won't use the ones that I designed?
I just wanted to say that I won't use them before that release ๐
Are you talking about the 15.1 release?
Are you talking about the 15.1 release?
Yes, so my plan is: Maybe like next week or so I'm planning to do the first beta release with the new emojis from Emoji 15.1 (emojis facing to the other side, phoenix, lime, etc.) and that is supposed to be the first release with your changes as well.
Additionally I'm thinking about reverting the file names to all be emoji_u...
again as it's easier to use them with the Noto-based toolsets, but if I do that I'll make that change after I merged your PR, so you don't have to do anything about that.
Okay. Hope this goes well!
Most changes look good to me, however:
u1f601
, the mouth looks too round.u1f628
's bigger mouth more.u1f62d
's tears should be changed to streams. This would be an exception, to make the pond visible, the streams and pond would be a white to dark blue gradient.u1f92e
should be green, other vendors do that too.u1f958
more, also we use blue-grey, not grey to represent metal here.u1f95e
should keep the plate.melting face
was more melty imo.saluting face
is just stupid, doesn't look like a hand, revert.Other changes are fine.
@C1710 also, if you do merge these, please correct the palette as most of them look copied straight from Noto
@Secret-chest, I will change some of them, but I have some stuff to say.
I didn't think the original versions of the humans were fitting because there's an outline.
The reason why the drops don't look white is because of a... reason. Even though there is a reason for this, I can't tell you, because the reason is inappropriate, but that's why I think people are going to look at it differently.
u1f92e
does not look green in most platforms: https://emojipedia.org/face-vomiting/
What "human emojis" are you talking about?
The ski emojis. They look copied from Noto. If anything, that light blue is the worst drop shade.
The thing is, the reason doesn't matter. White drops is one of the defining features of this set.
The ski emojis. They look copied from Noto.
This is the original version: And this is my version: I might change the drops.
But what is the Noto version?
This was the older Noto Color Emoji: This is the current one:
But what is the Noto version?
I think most of the ski people were copied from Noto, with only some variants being older; if I remember correctly, they originally (i.,e., before Noto ditched the Blobs) had no skin tones (because you can't see them anyway or so). Given that these emojis aren't really showing any faces, I think it's sufficient if the colors and flat design are there.
The thing is, the reason doesn't matter. White drops is one of the defining features of this set.
I personally just think that they make the emojis a bit simpler; ideally the faces should only use yellow, white, orange (with different tones for hands vs. mouths) and dark grey (I know that this is not the case, not even in those cases where it would work; I'm basically making up this rule right now). On the one hand, having them be blue can make sense to make it more explicit that it is water (it's also more consistent with other vendors). On the other hand I currently don't think that this is actually needed; people will probably still recognize that these are supposed to be drops of water and I don't think that it causes much confusion with other vendors either.
* The human emojis should not be changed since the style in Noto is different from the style we use here.
Are there really human emojis except for the ski people?
* Just my opinion, but the faces with teeth were cute. Additionally, in `u1f601`, the mouth looks too round.
Changing the teeth emojis was also one of the first things I did as the original ones looked a bit too robot-like to me, although I think some changes would make sense here
* I liked `u1f628`'s bigger mouth more.
This was also an early change I made to have the expression closer to the old version; it's just more exaggerated :D
* `u1f62d`'s tears should be changed to streams. This would be an exception, to make the pond visible, the streams and pond would be a white to dark blue gradient.
I don't like streams here (I don't want to make that decision unilaterally, though. It's just my opinion). Yes, everyone else uses streams here, but I don't see a big potential for confusion, but that might just be my personal usage and interpretation of this emoji.
* The `u1f92e` should be green, other vendors do that too.
While the others are actually not green, I think both versions would still be okay - it's more about the green that's coming out of the mouth; the green face just exaggerates that.
* I liked the old `u1f958` more, also we use blue-grey, not grey to represent metal here.
Maybe we could adapt it to have blue-grey for the metal? The contents of the pan are different for most vendors nowadays (I think there was even some discussion about it to not show specific ingredients)
* The old `melting face` was more melty imo.
That's something I agree with, but both versions would work
* The new `saluting face` is just stupid, doesn't look like a hand, revert.
With the updated hand it would work, I'm just not sure if the added complexity really improves the emoji, but I'm clearly biased here, as I know that the orange "thing" is supposed to be a kinda blobby hand. Maybe others don't understand it correctly.
If you couldn't tell I changed some of them. Do you think the change was for the better?
If you couldn't tell I changed some of them. Do you think the change was for the better?
Yeah, I think the recent changes did improve the designs (from my perspective). I'm still not completely happy with the teeth though - the newer version might lack a bit of contrast at emoji sizes, but I still think that it looks better than the black lines. I might try to find a design for that myself, but not today ๐ .
I decided to make the lines darker.
I also made changes to the headstone and coin.
Are you doing the changes or are these recommendations?
Are you doing the changes or are these recommendations?
I have the SVGs locally, but I don't just want to overwrite what you're doing, so for now they're mainly suggestions ๐
Also, what is the suggestion for the laughing emoji?
Also, what is the suggestion for the laughing emoji?
To just not change it, I guess? But I thought you were referring to the two emojis where I added alternate designs to the comments ๐
I thought you made a comment on emoji_u1f602.svg
though.
I thought you made a comment on
emoji_u1f602.svg
though.
Okay, I understand now. I talked about the version that's currently in the set; moving the mouth a bit upwards is just a pretty recent change I made ๐
I made the mouth move down because the current one looked weird.
The flag emojis are inconsistent. Can you please change them? I don't think I would want to edit flags. Also, why are there now conflicts?
The flag emojis are inconsistent. Can you please change them? I don't think I would want to edit flags.
No, I won't change the flags, especially if I don't know how they should be inconsistent. The waved style is applied automatically.
Also, why are there now conflicts?
I changed the target branch from main
to emoji15.1
, as that is the one these updates should be merged into. However, I changed some designs myself, so it now displays them as confilcts.
Are you still gonna merge this pull request?
Are you still gonna merge this pull request?
For most emojis, yes - switching the target branch to emoji15.1
was just because I want to include it with that release.
However there are 16 emojis which I would not want to merge, I think:
Additionally, I think your last commit/merge broke the files.
I tried to "resolve conflicts" and that didn't work. ๐ฌ
I tried to "resolve conflicts" and that didn't work. ๐ฌ
Don't worry, I'll look at it tomorrow ๐
If they will be broken forever, here's the ZIP file: Emojis.zip I hope this works.
How do you stop yourself from merging the files?
If they will be broken forever, here's the ZIP file: Emojis.zip I hope this works.
That's actually the one nice thing about Git: Nothing is lost. We can revert that broken merge and then fix it. But not today anymore :D
Also, when I installed the fork, the SVGs looked normal.
Can you only revert that commit or will it affect the other commits?
@C1710, I saw the SVGs on GitHub and they don't look broken, but the commit still thinks it's broken. Does that still mean that the files are broken?
I made some changes. Do you think they're better?
@C1710, I know that you are probably busy, but please respond.
I know this is a lot, but I feel that I should update some of them. Apologies if it adds files instead of updating them. By the way, what is the disguised face based on?