Closed Bronnel721 closed 1 year ago
@C1710, what do you think about these changes? I know there's a lot, but I had to change these emojis.
So, do you think that these changes are good? I hope I don't need to add anymore.
@C1710, I think I'm done with adding changes for now. If I want to, I would just make another pull request eventually. Also, the neutral-gendered person kneeling emojis aren't in the font, but there are SVGs of them.
Sorry, I don't have much time right now to review this PR, so it'll probably take a few weeks until I can give feedback.
That's okay, but I do have to say something. In my opinion, your normal color palette should have the values 117, 127, 63
, and have the lighter/darker versions of that color. For the skin tone color palette, the face should get a little darker as the skin got darker, and the opposite should happen for the lighter skin, just like what Google did. (Copy the values of the emojis that have darker and lighter skin tones, and paste them into the code.) You don't have to do it right now though, do it when you feel like it.
@C1710, am I allowed to edit the color palette?
@C1710, am I allowed to edit the color palette?
Depends on what exactly. I know it's not perfect, but it shouldn't deviate from the colors that were used in the original set too much. For example, I would agree that we need some warm brown tone in some cases.
If I could edit it, I would put the values 117, 127, 63
for a dark lime-900
.
@C1710, I updated the color palette so that lime-800
could have the values 141, 148, 58
, and that lime-900
had the values 117, 127, 63
. Does that sound good?
@C1710, if you merge this pull request, make sure to fix the bald emojis because they don't have ears.
Make smaller PRs so we can selectively merge them.
@Secret-chest, Yeah, I'll try to, but it won't be easy.
So, I'm going to open another pull request.
I know you said not to change anymore, but now I'm realizing there's more things that in my opinion look like they don't fit (specifically the emojis that were added in Android Nougat). You've forgot to remove the shiny spot on some buttons, if you didn't know (for example: π °,π ±,π,π,π,π,π,π,π,π,π,π,π,π,π,π―,π΅,andπΊ), the bald people emojis have no ears, and the people riding a horse emojis are all male. Correct the color palette.