C1rdec / Poe-Lurker

Ease your trading experience in Path of Exile.
MIT License
564 stars 53 forks source link

"Add Sextant" commit partially works #390

Closed joestrach closed 1 year ago

joestrach commented 1 year ago

Describe the bug Depending on how the direct whisper is created (either from bulk or main trade site) the value for the currency is either "Awakened Sextant" or "awakened-sextant".

POELurker only correctly parses whispers from the Bulk Trade portion of poe.sale.

To Reproduce Steps to reproduce the behavior:

  1. List a memory for sextants.
  2. Go to https://www.pathofexile.com/trade/exchange/Crucible/a05qwyBTe and replace YourAccountName with your account name.
  3. Whisper for the item. Valid artwork ✅
  4. Go to https://www.pathofexile.com/trade/search/Crucible/vYglQOLcE and replace YourAccountName with your account name.
  5. Whisper for this item. Invalid artwork ❌

Expected behavior Both types of whispers display the sextant artwork.

Screenshots

From Trade

1683146198-Awakened_PoE_Trade

From Bulk Trade

1683146236-Awakened_PoE_Trade

Please complete the following information:

C1rdec commented 1 year ago

Thanks for letting me know I will fix it 💪

joestrach commented 1 year ago

Thanks, I was going to give it a crack myself but I'm a python developer by trade and I had the suspicion that the "Sextent" aliased as "awakened-sextant" would be a bigger undertaking than updating some map somewhere 👍

Appreciate it! I love this addon.

C1rdec commented 1 year ago

Fixed in 1.21.15