search

C1rdec / Poe-Lurker

Ease your trading experience in Path of Exile.
MIT License
564 stars 53 forks source link

Invite-Hotkey is installed by default (Numpad2) but shouldn't because it can't be changed in the UI #400

Closed C3ntraX closed 1 year ago

C3ntraX commented 1 year ago

Describe the bug I was always wondering, why I cant split my currency when I typed 2 with my numpad. And now I know whats the root problem of this (see the screenshot).

The problem is, you defined hotkeys which I cant change in your UI settings. This is the "Invite" Hotkey, which has no UI-Settings and is for my "NumPad2". But I need "NumPad2" to split currency and other items. This is a big issue in my eyes because people dont kn ow where you save the HotKeys.json and dont know how to remove the NumPad2 hotkey or other hotkeys, which are binded by default. I had to fork and search for the json file to finally find the root problem.´

To Reproduce

Expected behavior Hotkeys-Settings which are not accessible via the UI shouldn't be installed by default.

Screenshots image

Please complete the following information:

Additional context Add any other context about the problem here.

C1rdec commented 1 year ago

There is no default value you setup this hotkey

Open up the settings

C3ntraX commented 1 year ago

And how does this value was coming into this Json file? Old version maybe?

C1rdec commented 1 year ago

It must be because PoeLurker do not have any default hotkey.

The code registering the old config as a hotkey. I will remove that