C2DH / journal-of-digital-history-backend

backend for our Journal of Digital History
MIT License
4 stars 0 forks source link

Identify all the manual steps perform during the technical review and automatize #172

Closed eliselavy closed 11 months ago

eliselavy commented 1 year ago

Identify all the manual steps perform during the technical review in order to perform automatically

eliselavy commented 1 year ago
eliselavy commented 1 year ago

script need to be integrated here: https://github.com/C2DH/journal-of-digital-history-ipynb-preflight-action/actions/runs/4342893071/jobs/7584262436

eliselavy commented 1 year ago
eliselavy commented 1 year ago

For the external library, add a check on the output

"outputs": [
    {
     "data": {
      "text/html": [
       "        require.undef(\"plotly\");\n",
       "        **define**('plotly', function(require, exports, module) {\n",
eliselavy commented 1 year ago

For the citation as cite2c and citation manager don't take into account the group , add a check by calling zotero api

biumiamy commented 1 year ago

For the script result, added a first demo gif to the guideline

eliselavy commented 1 year ago

For the checkoutput.py

Need to look at all type of outputs:

eliselavy commented 12 months ago

Need to improve the checkurl: https://github.com/C2DH/journal-of-digital-history-ipynb-preflight-action/blob/master/checks/checkurls.py as many urls here are valid and considered as false https://github.com/jdh-observer/m5GhKrrErgfE/blob/main/report.md

eliselavy commented 12 months ago

Problem to run the action: https://github.com/jdh-observer/FYjDViXVXggz/actions/runs/6262624601/job/17005229904#step:12:147

Screenshot 2023-09-21 at 15 55 22

eliselavy commented 12 months ago

Script more restrictive in github action Error: Invalid format '- https://licensebuttons.net/l/by/4.0/88x31.png)](https://creativecommons.org/licenses/by/4.0/ returned a 404 status code.'

https://github.com/jdh-observer/m5GhKrrErgfE/actions/runs/6263047507/job/17006567430

eliselavy commented 11 months ago

Deliver in the https://github.com/C2DH/template_repo_JDH and in the https://github.com/C2DH/template_repo_JDH_R

eliselavy commented 10 months ago

Tested action : https://github.com/marketplace/actions/markdownlint-cli2-action But permissive with html tag https://github.com/jdh-observer/48RGuzM4qfVA/actions/runs/6654446381