Open eliselavy opened 10 months ago
Another notebook choosen: https://github.com/jdh-observer/jnkqqTTKW8km
Testing:
See: https://github.com/C2DH/journal-of-digital-history/pull/560
See slack discussion https://c2dh.slack.com/archives/C065JHWDCF7
R notebook: R kernel not taken into account
Notebook with javascript, need to manage the flag: /c2dh/journal-of-digital-history/src/components/ArticleV3/Article.js
iv className={`ArticleLayer_cellActive off`} />
<SimpleArticleCell
isJavascriptTrusted={false}
onNumClick={() => ({})}
memoid={[url, idx].join('-')}
{...cell}
Button 'Reset all' need to bring back the cell input and not only output
Problem ressources not found by using Binder: execute-error - [Errno 2] No such file or directory: 'table28-cromwell_northernireland.csv'
Jupyter button needs to take binder url from api
Test made on : https://deploy-preview-637--journalofdigitalhistory.netlify.app/
Example coming from: https://deploy-preview-637--journalofdigitalhistory.netlify.app/en/article/L2gBr3BzwH8Z?v=3
https://journalofdigitalhistory.org/api/articles/L2gBr3BzwH8Z/
"binder_url": "https://mybinder.org/v2/gh/jdh-observer/jdh001-L2gBr3BzwH8Z/main?filepath=skim-article.ipynb"
Test made on : https://deploy-preview-637--journalofdigitalhistory.netlify.app/
- ?v=3&kernelname=IR not yet taken into account
- problem output javascript not displayed
- binderurl not taken from the API
Example coming from: https://deploy-preview-637--journalofdigitalhistory.netlify.app/en/article/L2gBr3BzwH8Z?v=3
https://journalofdigitalhistory.org/api/articles/L2gBr3BzwH8Z/
"binder_url": "https://mybinder.org/v2/gh/jdh-observer/jdh001-L2gBr3BzwH8Z/main?filepath=skim-article.ipynb"
All points fixed Testing made Need to see the problem with the graph of Edge Cases: The Making of Network Navigator and Critical Approaches to DH Tools article
but in this article generated perfectly: https://journalofdigitalhistory.netlify.app/en/article/VeaK58WBs82C?v=3
Thebe integration : plan + use case
Kick-off meeting: 9 november Start of the mission: 13 november
Provide 2 uses case: