C2DH / journal-of-digital-history-backend

backend for our Journal of Digital History
MIT License
4 stars 0 forks source link

Thebe integration : plan + use case + testing #211

Open eliselavy opened 10 months ago

eliselavy commented 10 months ago

Thebe integration : plan + use case

Kick-off meeting: 9 november Start of the mission: 13 november

Provide 2 uses case:

eliselavy commented 9 months ago

Another notebook choosen: https://github.com/jdh-observer/jnkqqTTKW8km

Testing: See: https://github.com/C2DH/journal-of-digital-history/pull/560

See slack discussion https://c2dh.slack.com/archives/C065JHWDCF7

eliselavy commented 9 months ago
eliselavy commented 5 months ago

Jupyter button needs to take binder url from api

eliselavy commented 1 month ago

Test made on : https://deploy-preview-637--journalofdigitalhistory.netlify.app/

Example coming from: https://deploy-preview-637--journalofdigitalhistory.netlify.app/en/article/L2gBr3BzwH8Z?v=3

https://journalofdigitalhistory.org/api/articles/L2gBr3BzwH8Z/ "binder_url": "https://mybinder.org/v2/gh/jdh-observer/jdh001-L2gBr3BzwH8Z/main?filepath=skim-article.ipynb"

eliselavy commented 1 month ago

Test made on : https://deploy-preview-637--journalofdigitalhistory.netlify.app/

  • ?v=3&kernelname=IR not yet taken into account
  • problem output javascript not displayed
  • binderurl not taken from the API
Screenshot 2024-07-24 at 17 40 40

Example coming from: https://deploy-preview-637--journalofdigitalhistory.netlify.app/en/article/L2gBr3BzwH8Z?v=3

https://journalofdigitalhistory.org/api/articles/L2gBr3BzwH8Z/ "binder_url": "https://mybinder.org/v2/gh/jdh-observer/jdh001-L2gBr3BzwH8Z/main?filepath=skim-article.ipynb"

All points fixed Testing made Need to see the problem with the graph of Edge Cases: The Making of Network Navigator and Critical Approaches to DH Tools article

but in this article generated perfectly: https://journalofdigitalhistory.netlify.app/en/article/VeaK58WBs82C?v=3