C2DH / journal-of-digital-history-ipynb-preflight-action

This GitHub action provides a set of tools to facilitate the life of reviewers
GNU Affero General Public License v3.0
0 stars 0 forks source link

Nbconvert workflow #4

Closed eliselavy closed 6 days ago

eliselavy commented 5 months ago

By looking at this

https://innerjoin.bit.io/automate-jupyter-notebooks-on-github-9d988ecf96a6

jupyter nbconvert --execute --to notebook --inplace --ExecutePreprocessor.timeout=-1 article.ipynb

eliselavy commented 2 months ago

Simple example with only markdown cell: https://github.com/C2DH/journal-of-digital-history-ipynb-preflight-action/blob/master/example/checkmd.ipynb

Example with code https://github.com/C2DH/journal-of-digital-history-ipynb-preflight-action/blob/master/example/plotly.ipynb

eliselavy commented 2 months ago

@memerchik in fact this action need to be in a separate one this action will be trigger at each pull request made on the .ipynb

see here https://innerjoin.bit.io/automate-jupyter-notebooks-on-github-9d988ecf96a6

Screenshot 2024-06-19 at 14 13 32
eliselavy commented 2 months ago

@memerchik error by running here https://github.com/jdh-observer/6ig87tC5GKjQ/actions/runs/9806613804/job/27078719297#step:6:375

why look for spacy as in the requirements.txt only two packages defined see here

eliselavy commented 2 months ago

@memerchik https://github.com/jdh-observer/6ig87tC5GKjQ/actions/runs/9806719790/job/27079035141

eliselavy commented 1 month ago

Need to set up right correctly 1s

Run gh pr create -B master -H nbconvert --title 'Comparison between nbconvert review of the article and the main article' --body 'Created by Github action'
pull request create failed: GraphQL: GitHub Actions is not permitted to create or approve pull requests (createPullRequest)
Error: Process completed with exit code [1](https://github.com/jdh-observer/8X2RX68Qavxr/actions/runs/10321601156/job/28574873507#step:9:1).
eliselavy commented 1 month ago

Need to set up right correctly 1s

Run gh pr create -B master -H nbconvert --title 'Comparison between nbconvert review of the article and the main article' --body 'Created by Github action'
pull request create failed: GraphQL: GitHub Actions is not permitted to create or approve pull requests (createPullRequest)
Error: Process completed with exit code [1](https://github.com/jdh-observer/8X2RX68Qavxr/actions/runs/10321601156/job/28574873507#step:9:1).

Fixed

Screenshot 2024-08-09 at 17 24 38
eliselavy commented 1 month ago

Now following error: @memerchik

https://github.com/jdh-observer/8X2RX68Qavxr/actions/runs/10321719758/job/28575261475

0s
Run gh pr create -B master -H nbconvert --title 'Comparison between nbconvert review of the article and the main article' --body 'Created by Github action'
pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, No commits between master and nbconvert, Base ref must be a branch (createPullRequest)
Error: Process completed with exit code [1](https://github.com/jdh-observer/8X2RX68Qavxr/actions/runs/10321719758/job/28575261475#step:9:1).
eliselavy commented 6 days ago

Fixed - work - https://app.reviewnb.com/jdh-observer/8X2RX68Qavxr/pull/1/