C2DH / journal-of-digital-history

frontend app for our Digital Journal
GNU General Public License v3.0
20 stars 4 forks source link

Bibliography filters UX issues #406

Closed biumiamy closed 2 years ago

biumiamy commented 2 years ago

show nothing instead of "show 0 more"

2022-04-06 20_41_48-Journal of Digital History

editorial for issue no. 2 rendered in notebook preview on journalofdigitalhistory.org

eliselavy commented 2 years ago

Wrong behaviour for the sort by year ASC - DESC in the bibliography

Screenshot 2022-04-08 at 17 25 09
biumiamy commented 2 years ago

actually regarding the design. I didnt understand ascending + descending, only after Elisabeth explained it to me. So I would propose to use arrows, this would be better. OR place the icon in front of the text

MacBook Pro 14_ - 1 (1)

MacBook Pro 14_ - 2 (1)

biumiamy commented 2 years ago

There seem to be errors still in the Kinora

2022-04-12 16_50_45-Replicating the Kinora - final changes 12-04-22 docx - Word

biumiamy commented 2 years ago

Because citation styles are different depending on the type (book, website, etc), sometimes authors are listed multiple times. @eliselavy suggested we add "type"

2022-04-13 16_02_06-Journal of Digital History

danieleguido commented 2 years ago

@biumiamy, can you check the current dev? The ordering looks ok to me now. The issue with the dupes is related on how they’re cited in the JSON metadata, the only solution is to correct the json property on the notebook itself. Here's an example:

"8918850/MIHD9AZ9": {
     "author": [
      {
       "family": "Jefferson",
       "given": "Thomas"
      }
     ],
     "id": "8918850/MIHD9AZ9",
     "issued": {
      "day": 13,
      "month": 11,
      "year": 1787
     },
     "title": "Thomas Jefferson to William Smith",
     "type": "personal_communication"
}

then the author appears as "Jefferson, Thomas" in the tag and it is correctly styled as Jefferson, T. (1787). Thomas Jefferson to William Smith [Personal communication]. The ordering is on the first uppercase letter of the family of the first author listed in the bibjson...