C2DH / journal-of-digital-history

frontend app for our Digital Journal
GNU General Public License v3.0
19 stars 4 forks source link

Tagging figure not clear for the authors #537

Closed eliselavy closed 1 year ago

eliselavy commented 1 year ago

During the technical review , really often now mistakes in the tagging figures ,see example below

Screenshot 2023-03-31 at 11 43 22

or here

Screenshot 2023-03-30 at 18 16 19
eliselavy commented 1 year ago

again another example see https://github.com/C2DH/jdh-notebook/issues/112

Screenshot 2023-04-06 at 14 37 06 Screenshot 2023-04-06 at 14 35 46
danieleguido commented 1 year ago

Hi, it seems that the tagging of figure we had before was simpler in the end :) to be discussed...

eliselavy commented 1 year ago
biumiamy commented 1 year ago

I added this section to the guideline(-styling notebook) to explain the figure naming:

figure-explanation

Do you think it is more clear now? @eliselavy @danieleguido ?

eliselavy commented 1 year ago

@biumiamy yes really clear in term of tagging, but maybe also insist that the same logic applies for tables , tag table-....

Maybe also a point of tagging is important so that items are reflected in the table of contents.

About the label, there is a mix in your example between metadata inserted at the level of the cell, and metadata pass in parameter in the display method. if markdown table for example , need to be inserted at the metadata cell level. Sometimes they are not aware where to find this metadata (see comment i made to author here https://github.com/C2DH/jdh-notebook/issues/105#issuecomment-1479717804)

Maybe a overview of the two methods.

eliselavy commented 1 year ago

@biumiamy you need to run the action https://github.com/C2DH/jdh-notebook/actions/workflows/github-actions-publishing.yml after having updating the guidelines notebook in order to have the version in production with the good size of the images

biumiamy commented 1 year ago

@eliselavy Should I always do the action after each commit? or after a I did a few corrections in a bundle? Probably each time I finished for the day. Perhaps that's the best.

Good point about the table!

About the ToC: do you mean on the frontend (with a name like "figure 1: blabla-name")? or in the Juypter Notebook ToC to see it while one writes?

About the metadata - are you refering to the part at the top? or the example images below? And what's the best way to display it then instead of how it is currently?

many questions :)

eliselavy commented 1 year ago

@biumiamy

biumiamy commented 1 year ago

updated the skim action to work for all Guideline notebooks