Closed biumiamy closed 8 months ago
I suggest to add a datatable-
tag to the table, so that I can add this component on top of the data https://tanstack.com/table/v8/docs/examples/react/basic
here's a example notebook with the table and references to it: https://github.com/C2DH/jdh-notebook/blob/master/examples/advanced_table.ipynb
Maybe in the TOC should be referenced also as table @biumiamy @danieleguido
@danieleguido example added in the https://github.com/C2DH/jdh-notebook/blob/master/examples/advanced_table.ipynb related to https://github.com/C2DH/jdh-notebook/issues/135#issuecomment-1863099654
Example coming from here: https://github.com/jdh-observer/4ZDXFXQwhoA8/blob/bdb87b8826c436907817b4fc9e5f172288496c95/delors_anonymised.ipynb
Problem display with the TOC - how to use it without retagging everything
For me problem of use, if this tag is assigned later in the publication process, for example design review, need to retag all. This data-table-* is more a designed tag for me.
Hi @eliselavy a solution to this problem could be:
table-
tagdata-table
tag
This way we can toggle the datatable feature without changing the ref to tables in the text of the article. Could this solve your issue? I've just merged in develop
, finally the fact of adding the data-table
tag hasn't any impact on the existing rules. Soon on develop :). I suggest to close this huge issue as the feature is out there. We can always create new issues if necessary.
By using this:
table appears two times
if you want to paginate with 20 lines, simply add the tag page-size-20, or for 3 lines page-size-3
By default pagination is : 10
Duplication of table fixed in the previous commit
Available in production : https://github.com/C2DH/journal-of-digital-history/releases/tag/v4.4.1
added it to the guideline as well:
user need from Chronoreferencing the Italian-Slovenian Borderlands
with line in focus so the reader doesn't need to search
two options for example: