C2DH / journal-of-digital-history

frontend app for our Digital Journal
GNU General Public License v3.0
19 stars 4 forks source link

advanced table #575

Closed biumiamy closed 8 months ago

biumiamy commented 1 year ago

user need from Chronoreferencing the Italian-Slovenian Borderlands

Image

Image

with line in focus so the reader doesn't need to search

Image

two options for example:

biumiamy commented 11 months ago

https://tanstack.com/table/v8/docs/examples/react/basic

danieleguido commented 11 months ago

I suggest to add a datatable- tag to the table, so that I can add this component on top of the data https://tanstack.com/table/v8/docs/examples/react/basic

biumiamy commented 11 months ago

here's a example notebook with the table and references to it: https://github.com/C2DH/jdh-notebook/blob/master/examples/advanced_table.ipynb

eliselavy commented 9 months ago

Maybe in the TOC should be referenced also as table @biumiamy @danieleguido

Image

eliselavy commented 9 months ago

@danieleguido example added in the https://github.com/C2DH/jdh-notebook/blob/master/examples/advanced_table.ipynb related to https://github.com/C2DH/jdh-notebook/issues/135#issuecomment-1863099654

eliselavy commented 8 months ago

Example coming from here: https://github.com/jdh-observer/4ZDXFXQwhoA8/blob/bdb87b8826c436907817b4fc9e5f172288496c95/delors_anonymised.ipynb

Problem display with the TOC - how to use it without retagging everything

Image

For me problem of use, if this tag is assigned later in the publication process, for example design review, need to retag all. This data-table-* is more a designed tag for me.

Image

danieleguido commented 8 months ago

Hi @eliselavy a solution to this problem could be:

danieleguido commented 8 months ago

I've just merged in develop, finally the fact of adding the data-table tag hasn't any impact on the existing rules. Soon on develop :). I suggest to close this huge issue as the feature is out there. We can always create new issues if necessary.

eliselavy commented 8 months ago

By using this:

Image

table appears two times

Image

eliselavy commented 8 months ago

if you want to paginate with 20 lines, simply add the tag page-size-20, or for 3 lines page-size-3

By default pagination is : 10

danieleguido commented 8 months ago

Duplication of table fixed in the previous commit

eliselavy commented 8 months ago

Available in production : https://github.com/C2DH/journal-of-digital-history/releases/tag/v4.4.1

biumiamy commented 7 months ago

added it to the guideline as well:

2024-02-02 10_29_26-Journal of Digital History