C2DH / journal-of-digital-history

frontend app for our Digital Journal
GNU General Public License v3.0
19 stars 4 forks source link

Thebe integration - initial exploration #588

Closed stevejpurves closed 10 months ago

stevejpurves commented 10 months ago

This PR uses some of the thebe-react providers and hooks to enable thebe in the ArticleV3 component.

https://github.com/C2DH/journal-of-digital-history/assets/1473646/f5ab0001-dcef-4bec-a83b-4f34017dc8bd

Idea here is that we can look at this versus current cell rendering in the JDH article, and better map out what a more complete implementation should look like.

Some points (non exhaustive) to consider are:

stevejpurves commented 10 months ago

Reflecting on the discussion points above, I think one of the most important early things to investigate is how thebe is integrated into the current ArticleCell code and to what extent ThebeNotebook/ThebeCell is used in that integration. We should consider the IsMagic and IsolatedRendering cases here.

stevejpurves commented 10 months ago

Brought these changes in, will open a further PR for visibility in on the next iteration