C2DH / tim

Timecode Indexing Module
https://c2dh.github.io/tim/
MIT License
6 stars 6 forks source link

Create keyboard shortcuts #40

Closed maboa closed 3 years ago

maboa commented 3 years ago
Description Shortcut
Pause / resume cmd/ctrl + ?
Skip forward cmd/ctrl + >
Skip back cmd/ctrl + b
Make selection a title cmd/ctrl + e
Make selection a synopsis cmd/ctrl + i
Make selection a keyword cmd/ctrl + k
Make selection a timecode / add timecode cmd/ctrl + j
Add multi-timecode shift + cmd/ctrl + j
maboa commented 3 years ago

The above seem to be safe on Chrome/Firefox on macOS. @overZellis133 @cartograforce please weigh in.

lwieneke commented 3 years ago

Not sure how far people are used to this already, but could we make that configurable? Alternatively I'd suggest

Description Shortcut
Pause / resume cmd/ctrl + s
Skip forward cmd/ctrl + d
Skip back cmd/ctrl + a
Make selection a title cmd/ctrl + e
Make selection a synopsis cmd/ctrl + i
Make selection a keyword cmd/ctrl + k
Make selection a timecode / add timecode cmd/ctrl + w
Add multi-timecode shift + cmd/ctrl + w

In that case we have the classical wasd key layout for the most common tasks

maboa commented 3 years ago

Many of those shortcuts will do other things in browsers unfortunately. there's only a limited number of keys we can use.

Making them configurable is a nice nice-to-have.

cartograforce commented 3 years ago

On the first two, are the ? and > just . and / ? Or do we need to hit shift too? They both require shift on my american keyboard.

cartograforce commented 3 years ago

I think making the 3 media player keys in a row somehow is strongly preferred. Zach and I just discussed... idealy those three keys can be executed with one hand. But maybe that's not possible while remaining comfortable. If we move to having to use two hands, then perhaps it opens up more keys, say if we make it cmd+Shift in the right hand and 123 (or asd) in the other. Note also the oTranscribe has two more keys to the right for changing the play speed, which would be nice someday. So ideally we pick something where it's possible later to add those those close by.

Laurian commented 3 years ago

which are the shortcuts in the end?

cmd+? is open help menu (mac) ctrl+k is delete line in Slate ctrl+b is move cursor one character back in Slate ctrl+e is move cursor at end of line in Slate cmd/ctrl+a is select all cmd/ctrl+s is save page in browser cmd/ctrl+w is close window

Laurian commented 3 years ago

we have:

cartograforce commented 3 years ago

Esc is working on local videos but not on Youtube videos like these:

https://youtu.be/2BGr3lzYZT0 https://youtu.be/2BGr3lzYZT0

https://youtu.be/QRE0GxT6Zbw

On 13 Nov 2020, at 11:32, Laurian Gridinoc notifications@github.com wrote:

we have:

cmd/ctrl+j for tc insert (TODO: toggle tc while inside one) esc play/pause ctrl+[ rewind skip ctrl+] forward skip — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Laurian/tim/issues/40#issuecomment-726686672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ7KUATWCUMCJBZD6J3GR7DSPUDK3ANCNFSM4TKFVNYA.

cartograforce commented 3 years ago

Also, would it be possible to make the timecode toggle 3-way as I thought we originally discussed?

On 13 Nov 2020, at 15:03, Douglas Lambert thedouglaslambert@yahoo.com wrote:

Esc is working on local videos but not on Youtube videos like these:

https://youtu.be/2BGr3lzYZT0 https://youtu.be/2BGr3lzYZT0

https://youtu.be/QRE0GxT6Zbw https://youtu.be/QRE0GxT6Zbw

On 13 Nov 2020, at 11:32, Laurian Gridinoc <notifications@github.com mailto:notifications@github.com> wrote:

we have:

cmd/ctrl+j for tc insert (TODO: toggle tc while inside one) esc play/pause ctrl+[ rewind skip ctrl+] forward skip — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Laurian/tim/issues/40#issuecomment-726686672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ7KUATWCUMCJBZD6J3GR7DSPUDK3ANCNFSM4TKFVNYA.

cartograforce commented 3 years ago

https://youtu.be/gyJk1UfWrRs

This video is not loading in our timeline/player either and the shortcuts aren't working.