search

C2DH / ww1

ww1 exhibition website
2 stars 1 forks source link

add scroll lock on module when object modal is open #123

Closed uf0 closed 6 years ago

uf0 commented 6 years ago

On modules when you click on the info button, the modal containing the information appears. If you scroll you will trigger the next module.

If modal is open we should apply the scrolllock component to prevent this issue

uf0 commented 6 years ago

Hi @gffuma , on desktop it's working but on mobile it's not because it disables "touch scroll" and we should add a prop touchScrollTarget to <ScrollLock /> component as documented here.

Here you can find an example (last comment).

I think we should pass as HTMLelement this one, but I can't understand how to do it with redux-saga