C2FO / fast-csv

CSV parser and formatter for node
http://c2fo.github.io/fast-csv
MIT License
1.66k stars 214 forks source link

Add support for multiple delimiters #1055

Open willm opened 2 weeks ago

willm commented 2 weeks ago

All Submissions:

New Feature Submissions:

  1. [x] Have you added tests for the new feature
  2. [x] Does your submission pass tests?
  3. [x] Have you lint your code locally prior to submission?
  4. [x] Have you updated the docs?
    • [ ] If you added new parsing or formatting options have you added them to the docs?
    • [ ] If applicable have you added an example to the parsing or formatting docs?

Changes to Core Features:

willm commented 2 weeks ago

Addresses #1054

juanri0s commented 1 week ago

@willm looks like CI tests are failing. Mind reviewing them? The suite was having issues before so it probably wasn't caught when you opened the PR.

willm commented 1 week ago

@juanri0s The issue #102 test was flaky due to not always completing in jest's default 5 second timeout, I increased the test timeout to 7 seconds. I hope this is acceptable, I'm pretty sure this was intermittently failing before my changes.