Local bigendian - Githubissues

C2QA / bosonic-qiskit

Extension of Qiskit to support hybrid boson-qubit simulations for the NQI C2QA effort.

BSD 2-Clause "Simplified" License

46 stars 11 forks source link

Local bigendian #54

Closed teaguetomesh closed 2 years ago

teaguetomesh commented 2 years ago

Merging in some of the changes I've made to my local version of c2qa-qiskit.

Allow the user to set the max-parallel-threads parameter when making calls to simulate
Allow QuantumRegisters to be added to a CVCircuit after it has been constructed. For this one I actually had some issues if I directly overloaded the qiskit .add_register function, so I changed the name to .add_qubit_register, the main thing is that CVCircuit._qubit_regs needs to get updated when this happens.

tjstavenger-pnnl commented 2 years ago

I realized after merging this wasn't into main, but into bigendian. I'm assuming it is still OK as the builds pass.

When we merge into main, we could consider using a parameter on simulate() that defines max_parallel_threads = 0 instead of using kwargs and the try/catch block