C2QA / bosonic-qiskit

Extension of Qiskit to support hybrid boson-qubit simulations for the NQI C2QA effort.
BSD 2-Clause "Simplified" License
51 stars 14 forks source link

Add support for animating Wigner functions with Parameterized circuits #60

Closed tjstavenger-pnnl closed 2 years ago

tjstavenger-pnnl commented 2 years ago

Kevin tried animating a parameterized circuit, but it failed. If we can get it working that would be helpful, but if not we should document that it won't work.

tjstavenger-pnnl commented 2 years ago

Adding a test to animate a bound parameterized circuit passed -- the animated GIF file is created. See https://github.com/C2QA/bosonic-qiskit/blob/main/tests/test_parameterized.py#L107-L135 and https://github.com/C2QA/bosonic-qiskit/actions/runs/3144377525

I'll follow up with @kevincsmith to see what I am doing differently in the test case vs what he did.

tjstavenger-pnnl commented 2 years ago

I wasn't able to reproduce via test case. We can reopen and correct any errors if we find a case that doesn't work.