Closed sadamov closed 1 year ago
I made some cosmetic changes to the docs and upgraded the python version. As these changes are so minor I don't think we need a separate PR.
thanks @sadamov for the contribution. In view of what was required to extend the installation to balfrin, I would like to propose a different mechanism to the installation procedure, based on the following thoughts:
I hope this helps, I let the main reviewer @victoria-cherkas to decide if that makes sense and whether it belongs to this PR or somewhere else.
Sorry I missed there was a PR for this issue, thanks @sadamov.
@cosunae I agree these all make sense, and remove the dependency on spack which would be great. I would propose that we do that in this PR, I can help with this.
Hope its OK, I added a refactor of the setup script with the changes outlined by @cosunae . While the re-gridding function points to fieldextra we would still need one if elif section to set the fieldextra path per machine, but elsewhere the script should now be machine agnostic.
Oh these are great suggestions, much easier setup now! I quickly tested it on Balfrin and Tsa and it works for me out of the box. 🚀
launch jenkins
Tests failing, because we are now using GRIB definition files from later eccodes version. I believe this newer eccodes version is required by current version of cfgrib. Looking into it
launch jenkins
launch jenkins
Jenkins tests passing with eccodes 2.25.0 and eccodes-cosmo-resources v2.25.0.1
Fixes #41