C2SM / iconarray

R&D Python package for processing ICON data with xarray
https://c2sm.github.io/iconarray/
BSD 3-Clause "New" or "Revised" License
10 stars 2 forks source link

functionality to crop ICON grid and data #9

Closed cosunae closed 2 years ago

cosunae commented 2 years ago

Technical Description

functionality to crop ICON grid and data. All full triangles (including its edges and vertices) whose cell center fall inside the lat/lon rectangle of the region of interest are included, meaning some edges / vertices with location outside of the region might be included

cosunae commented 2 years ago

launch jenkins

cosunae commented 2 years ago

launch jenkins

victoria-cherkas commented 2 years ago

Hi Carlos, apologies I have changed the flake8 config in the other documentation branch and would like this PR to conform to it:

These two (check_loc and latlon_spec ) are perhaps not public so should be made private (if they are):

Missing public module docstrings:

Can we add a brief desciption on more specifically what this test is testing?

Let me know if I can help with these changes

cosunae commented 2 years ago

launch jenkins

cosunae commented 2 years ago

launch jenkins

cosunae commented 2 years ago

launch jenkins

cosunae commented 2 years ago

I fixed the documentation issues you mentioned. However there are many more and I can not test/fix them since we have D1 ignored in the setup.cfg. I propose to activate D1 (or discuss the subset we want from D1) in a separate issue: https://github.com/C2SM/iconarray/issues/14

cosunae commented 2 years ago

launch jenkins