Closed cosunae closed 2 years ago
launch jenkins
launch jenkins
Hi Carlos, apologies I have changed the flake8 config in the other documentation branch and would like this PR to conform to it:
These two (check_loc and latlon_spec ) are perhaps not public so should be made private (if they are):
Missing public module docstrings:
Can we add a brief desciption on more specifically what this test is testing?
Let me know if I can help with these changes
launch jenkins
launch jenkins
launch jenkins
I fixed the documentation issues you mentioned. However there are many more and I can not test/fix them since we have D1 ignored in the setup.cfg. I propose to activate D1 (or discuss the subset we want from D1) in a separate issue: https://github.com/C2SM/iconarray/issues/14
launch jenkins
Technical Description
functionality to crop ICON grid and data. All full triangles (including its edges and vertices) whose cell center fall inside the lat/lon rectangle of the region of interest are included, meaning some edges / vertices with location outside of the region might be included