search

C2SM / pyvis

GNU General Public License v3.0
27 stars 12 forks source link

Some more language fixes I run into when going through the exercises #107

Closed AnnikaLau closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mathause commented 1 year ago

Thanks for all the language fixes!

AnnikaLau commented 1 year ago

@mathause : feel free to add any other language fixes to this pull request

chadhat commented 1 year ago

@AnnikaLau Can we merge this branch by tomorrow morning? So that we can update the jupyter hub.

AnnikaLau commented 1 year ago

@chadhat: I was planning to go through all exercises again today and would add anything to this pull request, which I stumble over. Could you update to the current version on jupyter hub and update again later in the evening today? There shouldn't be any essential changes in this pull request.

chadhat commented 1 year ago

@AnnikaLau we will update the jupyter hub setup. I can not promise that we can update it again this evening but as you said, these changes are not really critical.

chadhat commented 1 year ago

@AnnikaLau Thanks for the improvements. Since these are language fixes, I just glanced at a few of the changes. I assume that everything is fine and merge the branch

AnnikaLau commented 1 year ago

Thank you!