C2SM / pyvis

GNU General Public License v3.0
26 stars 12 forks source link

Add icon-vis exercise #86

Closed AnnikaLau closed 1 year ago

AnnikaLau commented 1 year ago

Let me know what you think of the exercise and the point above

chadhat commented 1 year ago

@AnnikaLau @mathause are you done with the changes on this branch?

mathause commented 1 year ago

I can go over it later.

AnnikaLau commented 1 year ago

I'm currently waiting for feedback from my co-developer of icon-vis Victoria Cherkas. So we could actually wait and see what she thinks.

AnnikaLau commented 1 year ago

I also created some slides to explain what icon-vis/psyplot/iconarray is. You can also have a look at them if you like: https://polybox.ethz.ch/index.php/s/azk90Dwvkh40LDK

AnnikaLau commented 1 year ago

I made some more changes according to Victoria's feedback.

@chadhat can you update the environment including adding icon-vis? I would still need to try out the exercises on the environment.

Apart from that I'm happy if you have a look at the exercise (again) and for your review.

AnnikaLau commented 1 year ago

@chadhat: From my side, I resolved all review comments. Please let me know if you are happy with the final version. Then we could merge and test it on the pre-installed environment.