search

C2SM / pyvis

GNU General Public License v3.0
26 stars 12 forks source link

fix exercise 5.3 #99

Closed mathause closed 1 year ago

mathause commented 1 year ago

There is no latex available so I had to remove all usetex=True. For some reason the formulas still render fine...?

Anyway, this was the minimum change to get the exercise working again. It would need a serious re-work - it's way too long and complicated. I don't have time for that so I tried to make sure it runs.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

AnnikaLau commented 1 year ago

Apart from this, it all looks fine. Maybe I'm also wrong about my comment above and it is actually supposed to be like this?

mathause commented 1 year ago

I just ran the cells after each (not paying too much account to the content so far) and I get exactly the same plot when running cell 8, 9, 10 and 12 (only counting code cells). I guess that's not supposed to be like this?

That was indeed a mistake - I am impressed by your keen eye! Thanks.

mathause commented 1 year ago

I'll merge this to get it out of the way ;-)