search

C2SM / spack-c2sm

Repository for c2sm spack config and repo files
https://c2sm.github.io/spack-c2sm/latest
MIT License
7 stars 19 forks source link

~aec variant needed for int2lm #312

Closed jonasjucker closed 2 years ago

jonasjucker commented 2 years ago

https://github.com/C2SM/spack-c2sm/commit/c285910fd6ad13e9871d814c529f7fc422760386 removed aec as variant from cosmo-eccodes-definitions, but int2lm still needs that option.

jonasjucker commented 2 years ago

@PanicSheep Could you fix this?

cosunae commented 2 years ago

this also confirms that for the new testing it is important that we thoroughly tests all the dependent packages, since we thought it would impact cosmo, but didnt realize also int2lm had the ~aec.

I think we should also remove ~aec from int2lm https://github.com/C2SM/spack-c2sm/blob/308dceb6fbc7eb2100bfc262cf3dea714150524b/packages/int2lm/package.py#L51

but we need to find a solution first created by https://github.com/C2SM/spack-c2sm/pull/300

cosunae commented 2 years ago

since I reverted #300, I removed the bug label

dominichofer commented 2 years ago

No more "aec" in int2lm.