search

C2SM / spack-c2sm

Repository for c2sm spack config and repo files
https://c2sm.github.io/spack-c2sm/latest
MIT License
7 stars 19 forks source link

[Oasis] add patch to fix broken makefile in 4.0 #980

Closed jonasjucker closed 1 month ago

jonasjucker commented 1 month ago

PSMILE makefile has wrong object deps. Only shows up for GCC compiler, hence not an issue so far. With moving COSMO and OASIS to Euler this error poped up.

diff --git a/lib/psmile/src/Makefile b/lib/psmile/src/Makefile                                                                    
index 50086e0d..94762839 100755                                                                                                   
--- a/lib/psmile/src/Makefile                                                                                                     
+++ b/lib/psmile/src/Makefile                                                                                                     
@@ -65,7 +65,7 @@ mod_oasis_mpi.o: mod_oasis_kinds.o mod_oasis_data.o mod_oasis_sys.o mod_oasis_ti                                
 mod_oasis_reprosum.o: mod_oasis_kinds.o mod_oasis_data.o mod_oasis_sys.o \                                                       
    |   |mod_oasis_timer.o shr_reprosumx86.o mod_oasis_mpi.o                                                                      
 mod_oasis_string.o: mod_oasis_kinds.o mod_oasis_data.o mod_oasis_sys.o \                                                         
-        mod_oasis_parameters.o                                                                                                   
+        mod_oasis_parameters.o mod_oasis_timer.o                                                                                 
 mod_oasis_namcouple.o: mod_oasis_kinds.o mod_oasis_data.o mod_oasis_sys.o \                                                      
    |   |mod_oasis_parameters.o mod_oasis_mpi.o mod_oasis_string.o                                                                
 mod_oasis_part.o: mod_oasis_kinds.o mod_oasis_data.o mod_oasis_sys.o \
github-actions[bot] commented 1 month ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-25 06:05 UTC

jonasjucker commented 1 month ago

launch jenkins oasis

jenkins-apn commented 1 month ago

balfrin

:green_circle: unit test
Test
:green_circle:summary
:green_circle: integration test
Test
:green_circle:oasis-spack_info
:green_circle:oasis-spack_spec
jenkins-apn commented 1 month ago

tsa

:green_circle: unit test
Test
:green_circle:summary
:green_circle: integration test
Test
:green_circle:oasis-spack_info
:green_circle:oasis-spack_spec
jenkins-apn commented 1 month ago

daint

:green_circle: unit test
Test
:green_circle:summary
:green_circle: integration test
Test
:green_circle:oasis-spack_info
:green_circle:oasis-spack_spec
:green_circle: system test
Test
:green_circle:install_oasis_version_4_0_nvhpc-oasis_@4.0_nvhpc
mathause commented 1 month ago

I can confirm that this compiles on euler with gcc 8.5.0 - thanks!

spack install oasis%gcc@8.5.0