C2SM / spack-c2sm

Repository for c2sm spack config and repo files
https://c2sm.github.io/spack-c2sm/latest
MIT License
7 stars 19 forks source link

[ICON] add nvtx as as variant to ICON #992

Open jonasjucker opened 2 months ago

jonasjucker commented 2 months ago

This variant enables to use nvtx ranges for profiling in a clean way.

github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://C2SM.github.io/spack-c2sm/pr-preview/pr-992/ on branch gh-pages at 2024-08-22 08:00 UTC

jonasjucker commented 2 months ago

launch jenkins all

dominichofer commented 2 months ago

Interesting! Can you upstream it to https://github.com/spack/spack too?

jenkins-apn commented 2 months ago

balfrin

:green_circle: unit test
Test
:green_circle:summary
:green_circle: integration test
Test
:green_circle:clang-format-spack_info
:green_circle:clang-format-spack_spec
:green_circle:cosmo-eccodes-definitions-spack_info
:green_circle:cosmo-eccodes-definitions-spack_spec
:green_circle:cosmo-spack_info
:green_circle:cosmo-spack_spec
:green_circle:ecbuild-spack_info
:green_circle:ecbuild-spack_spec
:green_circle:eccodes-spack_info
:green_circle:eccodes-spack_spec
:green_circle:fdb-fortran-spack_info
:green_circle:fdb-fortran-spack_spec
:green_circle:fdb-spack_info
:green_circle:fdb-spack_spec
:green_circle:flexpart-cosmo-spack_info
:green_circle:flexpart-cosmo-spack_spec
:green_circle:flexpart-ifs-spack_info
:green_circle:flexpart-ifs-spack_spec
:green_circle:icon-ham-spack_info
:green_circle:icon-ham-spack_spec
:green_circle:icon-spack_info
:green_circle:icon-spack_spec
:green_circle:icon_extra-config-args=--disable-new_feature,--enable-old_config_arg-spack_spec
:green_circle:dace_icon.-O1-spack_spec
:green_circle:icon_serialization=create-spack_spec
:green_circle:icontools-spack_info
:green_circle:icontools-spack_spec
:green_circle:int2lm-spack_info
:green_circle:int2lm-spack_spec
:green_circle:int2lm_+parallel-spack_spec
:green_circle:int2lm_~parallel-spack_spec
:green_circle:libcdi-pio-spack_info
:green_circle:libcdi-pio-spack_spec
:green_circle:libfyaml-spack_info
:green_circle:libfyaml-spack_spec
:green_circle:libgrib1-spack_info
:green_circle:libgrib1-spack_spec
:green_circle:libtorch-spack_info
:green_circle:libtorch-spack_spec
:green_circle:makedepf90-spack_info
:green_circle:makedepf90-spack_spec
:green_circle:metkit-spack_info
:green_circle:metkit-spack_spec
:green_circle:oasis-spack_info
:green_circle:oasis-spack_spec
:green_circle:py-cytoolz-spack_info
:green_circle:py-cytoolz-spack_spec
:green_circle:py-devtools-spack_info
:green_circle:py-devtools-spack_spec
:green_circle:py-factory-boy-spack_info
:green_circle:py-factory-boy-spack_spec
:green_circle:py-frozendict-spack_info
:green_circle:py-frozendict-spack_spec
:green_circle:py-gridtools-cpp-spack_info
:green_circle:py-gridtools-cpp-spack_spec
:green_circle:py-gt4py-spack_info
:green_circle:py-gt4py-spack_spec
:green_circle:py-hatchling-spack_info
:green_circle:py-hatchling-spack_spec
:green_circle:py-icon4py-spack_info
:green_circle:py-icon4py-spack_spec
:green_circle:py-inflection-spack_info
:green_circle:py-inflection-spack_spec
:green_circle:py-lark-spack_info
:green_circle:py-lark-spack_spec
:green_circle:py-pytest-factoryboy-spack_info
:green_circle:py-pytest-factoryboy-spack_spec
:green_circle:py-tabulate-spack_info
:green_circle:py-tabulate-spack_spec
:green_circle:py-typing-extensions-spack_info
:green_circle:py-typing-extensions-spack_spec
:green_circle:python-spack_info
:green_circle:python-spack_spec
:green_circle:pytorch-fortran-proxy-spack_info
:green_circle:pytorch-fortran-proxy-spack_spec
:green_circle:pytorch-fortran-spack_info
:green_circle:pytorch-fortran-spack_spec
:green_circle:scales-ppm-spack_info
:green_circle:scales-ppm-spack_spec
:green_circle:xpmem-spack_info
:green_circle:xpmem-spack_spec
:green_circle:yaxt-spack_info
:green_circle:yaxt-spack_spec
:green_circle: system test
Test
:green_circle:install_2024_1_nvhpc-icon_@2024.1-1_nvhpc
:green_circle:install_conditional_dependencies-icon_@2024.1-1_nvhpc_+coupling_serialization=create_+emvorado_+mpi_gpu=openacc+cuda_cuda_arch=80
:green_circle:install_cosmo_6_0-cosmo@6.0nvhpc
:green_circle:install_cosmo_eccodes_definitions_version-cosmo-eccodes-definitions_@2.19.0.7
:green_circle:install_cosmo_eccodes_definitions_version-cosmo-eccodes-definitions_@2.25.0.1
:green_circle:install_default-scales-ppm
:green_circle:install_eccodes_2_19_0-eccodes_@2.19.0
:green_circle:install_fdb_5_11_17_gcc-fdb_@5.11.17_gcc
:green_circle:install_fdb_5_11_17_nvhpc-fdb_@5.11.17_nvhpc
:green_circle:install_fdb_fortran-fdb-fortran
:green_circle:install_flexpart_cosmo-flexpart-cosmo_@V8C4.0
:green_circle:install_flexpart_ifs_version-flexpart-ifs_@10.4.4
:green_circle:install_flexpart_ifs_version-flexpart-ifs_@fdb
:green_circle:install_icon_24_1_gcc-icon_@2024.1-1_gcc
:green_circle:install_icontools-icontools_@2.5.2
:green_circle:install_int2lm_version_3_00_nvhpc_fixed_definitions-int2lm_@int2lm-3.00_nvhpc_^cosmo-eccodes-definitions@2.19.0.7nvhpc
:green_circle:install_libcdi_pio_default-libcdi-pio
:green_circle:install_libfyaml_default-libfyaml
:green_circle:install_libgrib1_22_01_2020_nvhpc-libgrib1_@22-01-2020nvhpc
:green_circle:install_libtorch_default-libtorch
:green_circle:install_makedepf90-makedepf90_@3.0.1
:green_circle:install_oasis_version_4_0_nvhpc-oasis_@4.0_nvhpc
:green_circle:install_py_gt4py_for_version-py-gt4py_@1.0.3.3
:green_circle:install_py_gt4py_for_version-py-gt4py_@1.0.3.7
:green_circle:install_py_gt4py_for_version-py-gt4py_@1.0.3.8
:green_circle:install_py_hatchling_default-py-hatchling
:green_circle:install_py_icon4py_version_0_0_10-py-icon4py_@_0.0.10_gcc_^py-gt4py@1.0.3.3
:green_circle:install_py_icon4py_version_0_0_11-py-icon4py_@_0.0.11_gcc_^py-gt4py@1.0.3.7
:green_circle:install_py_icon4py_version_0_0_12-py-icon4py_@_0.0.12_gcc_^py-gt4py@1.0.3.8
:green_circle:install_py_inflection_default-py-inflection
:green_circle:install_py_pyfactoryboy_default-py-pytest-factoryboy
:green_circle:install_py_tabulate_default-py-tabulate
:green_circle:install_py_typing_extensions_default-py-typing-extensions
:green_circle:install_pytorch_fortran_proxy_version_0_4-pytorch-fortran-proxy@0.4gcc_^python@3.10
:green_circle:install_pytorch_fortran_version_0_4-pytorch-fortran@0.4nvhpc_^pytorch-fortran-proxy@0.4gcc_^python@3.10_^gmakegcc_^cmakegcc
:green_circle:install_yaxt_default-yaxt
:green_circle:py_cytoolz_install_default-py-cytoolz
:green_circle:py_devtools_install_default-py-devtools
:green_circle:py_factory_boy_install_default-py-factory-boy
:green_circle:py_frozendict_install_default-py-frozendict
:green_circle:py_gridtools_cpp_install_default-py-gridtools-cpp
jonasjucker commented 2 months ago

Interesting! Can you upstream it to https://github.com/spack/spack too?

I was thinking about that. Looking at the package in spack it seems that only configure-option are included in the recipe. Since there is no --enable-nvtx as configure-option I would not clutter the recipe.

dominichofer commented 2 months ago

But it's okay to clutter ours?

jonasjucker commented 2 months ago

I think so, since we will use it and also know how to use it :-)

Also this is alligned with our goal to build a hierarchy of icon-recipes we would go from generic (spack recipe) nwp (spack-c2sm recipe) ...

dominichofer commented 2 months ago

It's okay to clutter software that MeteoSwiss' operations rely on, even though we don't think it's good enough for the public icon community? I don't understand this logic.

jonasjucker commented 2 months ago

Ok then you don't