search

C2SP / CCTV

Community Cryptography Test Vectors
https://c2sp.org/CCTV
64 stars 6 forks source link

Readme: low_order_R should be non_canonical_R #3

Closed botovq closed 1 year ago

botovq commented 1 year ago

The behavior exhibited by the ref10 implementation, in particular the code used by Go and various OpenSSL variants is to reject test vectors that have at least one of non_canonical_R and low_order_residue set.

botovq commented 1 year ago

This typo confused me for a while. I checked this with Go, LibreSSL 3.7 as well as OpenSSL 1.1, 3.0, and 3.1.The same should hold true for BoringSSL.

FiloSottile commented 1 year ago

Ah! Good catch and apologies for the confusion.

Indeed, the tests check for the correct flag.

https://github.com/C2SP/CCTV/blob/5ea85644bd035c555900a2f707f7e4c31ea65ced/ed25519vectors/ed25519vectors_test.go#L160-L161