search

C2linaung / pe

0 stars 0 forks source link

Editing the data files cause errors to occur #5

Open C2linaung opened 1 week ago

C2linaung commented 1 week ago

I edited the data file. with an additional comma to the field. Then i went back to the program and as you can see, the printed message is gone. This is a big issue since as the user, when i am updating the data files, I do not know that the error could occur if i added a comma. The program should detect that some input change has errors inside.

image.png

image.png

soc-pe-bot commented 3 days ago

Team's Response

Thank you for pointing this out to our team. We agree with your findings and acknowledge the mistake on our part. However, we feel that this should be classified as of low severity as this is from the result of directly manipulating the csv file content for the sake of changing a record. This would be quite uncommon as the normal user would usually perform all tasks and operations on the inventory through Inventra.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This still seems to me like a medium severity for the following reasons:

  1. There is no warning anywhere that states that I cannot have a comma (which seems to also be needed quite frequently).
  2. As a user I would still be inconvenienced heavily by this. In my inventory, i might want to describe the items in it and making use of a comma seems like a must in a lot of situations. Additionally, when using the csv file to edit, especially for those using excel, there is a tendency for it to add an extra comma for thousand separator when editing in the csv. In such cases, the program seems to not be able to give out the correct output.
  3. For a beginner, I might agree that using the csv file to update the data is quite uncommon. However, for advanced users, especially if the data is in a csv file format, and I have multiple entries (i'm talking like more than 20) I want to add in 1 go, I might decide to use the data file, since it seems to be much faster as compared to just typing on the CLI. This would mean that overtime, your "normal users" will extend to those that use the csv file frequently. Does it then not mean that it becomes more inconvenient as users learn more about the ways to use Inventra?
  4. To qualify as a Severity.low, it should only cause minor inconvenience and only occur in rare situations. As pointed out in point 3, it's not really a rare situation for users to decide to add data using the csv file, especially if it exists and the team put it as a feature. Additionally, I wouldn't consider failure to display information correctly as a rare situation, especially if the comma affects ANY of the fields the user decide to add it in.
  5. To qualify as a Severity.medium, the flaw would cause occasional inconvenience to some users. In this case, it causes inconvenience to all my advanced users of the product and the flaw seems to cause inconvenience quite frequently since a comma can be used in any of the fields (by field, i mean the empty boxes to input values in excel). Furthermore, even without using the data file, banning the use of a comma (which wasn't even stated) in itself is a flaw since it is used so commonly.

image.png

image.png