Allow the volume panel to expand taking up all the space

C3C0 / GravityBox

This repository is deprecated. Official one is maintained under GravityBox organization

https://github.com/GravityBox/GravityBox

92 stars 355 forks source link

Allow the volume panel to expand taking up all the space #232

Closed MohammadAG closed 10 years ago

MohammadAG commented 10 years ago

Best way to explain this: Before: http://i.imgur.com/2mrdoeil.png After: http://i.imgur.com/pMZE4MGl.png

This isn't specific to Xperia devices afaik, though I've only tested it on one.

MohammadAG commented 10 years ago

Updated pull request, I was creating two hooks for the same method.

C3C0 commented 10 years ago

Great job! Will take care of it tomorrow. Thanks.

C3C0 commented 10 years ago

Maybe we don't even need a preference for it. This should be a default behaviour. Would save some work for translators, too :) What do you think?

bgcngm commented 10 years ago

I also agree. That should be the behavior.

MohammadAG commented 10 years ago

I personally see this as the better looking alternative. The other one just looks weird, but I've seen many users getting pissed about how an update changed previous behavior, which is why I added the setting.

C3C0 commented 10 years ago

Tested and working fine on my device.

bgcngm commented 10 years ago

So, are we going to keep the preference? Just need to know if I should translate it or not.

C3C0 commented 10 years ago

Let's keep it.