C3C0 / GravityBox

This repository is deprecated. Official one is maintained under GravityBox organization
https://github.com/GravityBox/GravityBox
92 stars 356 forks source link

Update Location & GPS tile strings #304

Closed tonyp closed 10 years ago

tonyp commented 10 years ago

The new KK Location tile actually is different to the old GPS one. It does toggle whatever Location mode you have set (high accuracy, battery saving, device only), not just GPS. So it's capable of toggling Google's Wi-Fi location service (provided by GSF) as well.

Speaking about which: it could use an option in the "override default tile behaviour" section as well, as you're currently still required to longpress it :)

C3C0 commented 10 years ago

These strings are shared across all Android versions. For KK, new strings have to be created instead of modifying existing ones. They have to be then referenced in qs_tile_aosp_entries_kk string-array in arrays.xml. Thanks, anyway.

tonyp commented 10 years ago

Ah makes sense. I've read you're planning to fork of kitkat anyways, it's nothing important so it can easily wait until then. The less API differentiation you're including now the less you have to revert later :)

I'd like to thank you here for this excellent toolset and your dedication. I used to build my own ROM with custom cherrypicks to include the features I like, thanks to you (and rovo of course) I can keep the Stock ROM on my Nexus 5. Brilliant!

C3C0 commented 10 years ago

:+1: