search

C3ETH / c3eth-captions

Cardano Catalyst Community Eastern Townhall SRT caption files for videos produced by the team.
Other
1 stars 0 forks source link

feat(content): Captions translation of Fund6 Proposal Video #14

Closed gitlocalize-app[bot] closed 2 years ago

gitlocalize-app[bot] commented 2 years ago

All translations have been done. See review request for onboarding-east-asia-today-captions.md on GitLocalize See review request for connect-east-asian-entrepreneurs.md on GitLocalize See review request for grow-east-asia-captions.md on GitLocalize See review request for onboarding-east-asia-today-captions.md on GitLocalize

wolstaeb commented 2 years ago

fyi. @YanTirta I've applied all the translations included in this PR. It is awesome you've a.) done the PR, and b.) included all the changes in one PR. It Will eventually saves me a heap of time. Unfortunately, it is not clear in the Gitlocalize interface which translations have been applied and which have not. But that is a small issue we will figure out.

YanTirta commented 2 years ago

Well noted and pardon if I somehow contributed to causing the confusion. When the issues have been figured out, please teach me what would be the best way forward in the future to further ease your workload and to further iterate an even efficient pipeline for translation.

wolstaeb commented 2 years ago

Well noted and pardon if I somehow contributed to causing the confusion.

No confusion @YanTirta. I thought it was great! I originally thought these changes had already been merged but they had not. See how people in the team do things and where we get confused or double up, is helping me figure out better approaches.

When the issues have been figured out, please teach me what would be the best way forward in the future to further ease your workload and to further iterate an even efficient pipeline for translation.

What you have done above is great, adding all your approved translations into a single Pull Request (PR). Even if there is a double-up it is pretty easy to merge everything. What I would suggest is when you Translated/Approve changes you then do a PR for them all. As you have done here. With one exception, only include the files with the translations you've approved.

This may be a little confusing at the moment because you're both the translator and moderator. However, the intention is that you would only moderate translations, add comments (to help new translators), and when you've approved everything batch them up into a PR ready for merging back into the main repository.

This rough workflow will work for doing the video captions and for content on the website.

YanTirta commented 2 years ago

Well noted Robert, I will probably bumble my way into understanding. But as to not bumble too much;

What I would suggest is when you Translate/Approve changes you then do a PR for them all. As you have done here. With one exception, only include the files with the translations you've approved.

as mentioned above; "...only include the files with the translations you've approved." ---> would this mean only checking the green box that correlates with the edited translation of the first translation?

wolstaeb commented 2 years ago

As you complete a set of tasks of translations/approvals, then include those files in the PR, nothing else.

YanTirta commented 2 years ago

Noted. Thank you Robert.