search

C3RV1 / UndertaleNDS

Undertale port for Nintendo DS (src only, no copyrighted material).
GNU General Public License v2.0
179 stars 24 forks source link

Issue with new patching system #7

Closed godreborn closed 1 year ago

godreborn commented 2 years ago

hey, this is godreborn from temp. I just tried your new patches, but there's a problem. it will only let me apply one of them. I'm assuming it's looking for the right checksum, which has obviously changed after patching it once. I think all three are looking for an unmodified file. I'm not sure how to proceed.

C3RV1 commented 2 years ago

All of them should be applied to an unmodified file as they result in different project files. Sorry about not specifying it on the README. I'll add it soon.

godreborn commented 2 years ago

do you mean we need three data.win files? because it will not let me apply more than one patch. it doesn't matter which patch it is.

C3RV1 commented 2 years ago

yes. just make 3 copies and apply a different patch for each of them. however, if you just want to play the game without building it, patching just for the Undertale.nds file will be enough

godreborn commented 2 years ago

here's what happens if I try extracting the assets:

image

C3RV1 commented 2 years ago

To get those missing files, needed for building, you need to patch a data.win with tools.zip.ups to get tools.zip. This zip file contains the files needed for building the game, which need to be extracted into the tools directory directly (like "merging" the content of the zip file with the contents of the folder). Then, you should be able to run tools/all.py. However, if you're just looking to test the ROM, there's no need for that. Undertale.nds should work directly on an emulator.

PS: sorry, I'm awful at explaining

godreborn commented 2 years ago

after you patch it, you should get a tools.zip? I did not.

C3RV1 commented 2 years ago

I think so, you should get a tools.zip by patching it with tools.zip.ups

godreborn commented 2 years ago

I did not get anything.

godreborn commented 2 years ago

I figured out the problem. it doesn't rename the data.win. the data.win is the zip file.

C3RV1 commented 2 years ago

Ohhh okay, I didn't know about that behaviour

godreborn commented 2 years ago

there's still a problem. I did both nitrofs and tools, then I patched the win file with its patch. after that, I tried the python command, and this happened:

image

C3RV1 commented 2 years ago

oh god I forgot to remove the debug prints... well until I get that fixed on the next release, you could edit pngToCbgf.py to remove all prints, which should correct this issue

godreborn commented 2 years ago

I renamed it to UndertaleNDS.nds like the ups shows, and it seemed to go through, but I'm not sure where the finished file is located:

image

C3RV1 commented 2 years ago

There's no need to do all of this if you just wish to play, are you sure you need to build it yourself?

godreborn commented 2 years ago

just trying to learn how to build it with the new patches. the original ones I didn't have a problem with. also, a couple people in your thread on temp wanted to know how to build it. that's when I noticed the instructions were different.

C3RV1 commented 2 years ago

mhm I know, the other instructions were more automated. right now I don't know exactly what's the issue, and I don't have the time right now to work on it. I'll work on better and more straightforward instructions when I can, sorry :(

velamyGH commented 1 year ago

new (working) patching system, u can probably close this now me thinks

godreborn commented 1 year ago

yeah, works fine for me with the new patching system:

image