C4K3 / ozelot

Rust library for handling all MCMODERN networking
Creative Commons Zero v1.0 Universal
34 stars 9 forks source link

Expose deserialization methods as public. #7

Closed cedws closed 5 years ago

cedws commented 5 years ago

Hi there. I would like to use Ozelot as a library for an experimental server project. It seems that packets such as ozelot::serverbound::Handshake do not expose deserialize as public. Is there a reason for this?

C4K3 commented 5 years ago

There's no real reason besides I don't have any use for them being public. If you do have a use for them being public, then I see no reason we couldn't just make them public.

cedws commented 5 years ago

Great! Please take a look at my PR when you have the time. I really like the way you use Clojure to do the codegen.