C4illin / ConvertX

💾 Self-hosted online file converter. Supports 800+ formats
GNU Affero General Public License v3.0
229 stars 3 forks source link

Feature: Unauthenticated file conversions #114

Closed luis-c465 closed 2 weeks ago

luis-c465 commented 4 weeks ago

Would be great if there was an environment variable to allow users to convert files with ought having to sign in first. Is this possible or safe with how the app is currently built?

C4illin commented 3 weeks ago

Is it ok if The unauthorized user can see all conversions? That would be quite easy to do

101br03k commented 3 weeks ago

for me this would be fine since everything in my stack is only local accessibel.

egodigitus commented 3 weeks ago

Would be in favor of this feature as well. I would suggest to remove the history "feature" completely for unauthenticated users.

C4illin commented 2 weeks ago

Now it works by generating a random user id above the normal user ids and then signing a jwt with it. Creating a temporary guest user, so all features should still work. Test it and see if it works:)

luis-c465 commented 2 weeks ago

Tested in Docker and looks like conversion and file history work even when not signed in :)

As expected, I could not get other unauthenticated users to views the converted images even when knowing the URL of the image.