C4ptFuture / cdtv-os235patch

Patch a v2.30 CDTV OS ROM image to create a v2.35 image
GNU General Public License v3.0
31 stars 2 forks source link

U34/U35 issue #7

Open bordy12 opened 8 months ago

bordy12 commented 8 months ago

Hi, thank you for your effort into this project, I ran the patching docker in the past and a second time today but I noticed that the binaries CDTV_v2_35_U34_Even.bin and CDTV_v2_35_U35_Odd.bin were different from the ones I obtained the first time. Once burned into standard 27C1000 eprom the two roms didn't run and CDTV returned to the standard kickstart animation. I started with the 230.rom with the exact md5 specified in the documentation, no errors happened during the process. Once analyzed each new rom rom file has populated bytes starting hex 0x10000 inwards, while the ones I burned the first time don't, from that position they were simply empty. Am I missing something? In the picture on the left the right U34 dump from eprom I'm currently using in my CDTV and on the right the new rom U34 obatained today. rom_bad

C4ptFuture commented 8 months ago

Hi, thx for the report and for providing the screenshots, as that is very helpful! I am unfortunately not able to replicate the issue you were having. I have run the process from scratch several times both with the current version of the patch container (1.0.3) and the previous ones (1.0.2 and below) and I end up with identical bin files between these versions.

Some info on the bin files: The U34 and U35 bins should be 128K in size each ($20000) and filled with data for like 95%+. The file pictured on the left is not correct, because it only has data until $10000, which means it’s missing half of its data (everything between $10000-$1FFFFF). The one on the right looks fine (at least the part I can observe from the screenshot). 
For reference, these are the md5 hashes of the bin files if they have been generated correctly:

MD5 (CDTV_v2_35_U34_Even.bin) = 0be628f981ecf2ebbbc820bceff5acc4
MD5 (CDTV_v2_35_U35_Odd.bin) = 3788f918321db2761f2150a900f11bb1

If you still are able to replicate the issue of generating these faulty “half”-ROM bins, please do let me know and provide me with the exact steps (screenshot or copy paste output), because in that case I’d like to squash that bug. 😃 Thx again and thanks for using CDTV OS 2.35!!