search

C7-Game / Prototype

An early-stage, open-source 4X strategy game
https://c7-game.github.io/
MIT License
33 stars 9 forks source link

323 - Fix zombie units causing crashes #372

Closed QuintillusCFC closed 1 year ago

QuintillusCFC commented 1 year ago

This fixes a longstanding mysterious crash, which thanks to improved logging and the ability to set a fixed seed, was determined to be caused by zombie units.

These units no longer move around and cause crashes, and should be properly garbage collected the next turn now that they don't cause crashes.

You can use fixed seed 1626442457 to test this solving a crash that happens after turn 18. See the issue card for full notes.

Please review 357 first! The reproducible case for this depends on the changes made there.

WildWeazel commented 1 year ago

We'd better fix this soon, Halloween is coming up....

QuintillusCFC commented 1 year ago

Self-reviewed after 7 days since last comments, merging (not much time left till Halloween!).