search

C7-Game / Prototype

An early-stage, open-source 4X strategy game
https://c7-game.github.io/
MIT License
32 stars 9 forks source link

[4.x] Default font size 14 #418

Closed QuintillusCFC closed 10 months ago

QuintillusCFC commented 11 months ago

Sets the default font size to 14, and sets it to use Noto Sans. 14 was the default in Godot 3.x; this causes it to match existing functionality. Downside, for some reason the overrides to font size for things like headers in dialogs aren't working; I verified that they weren't without these changes either.

See Popup.js, AddHeader method as an example of where we have an override that worked in 3.5 but doesn't in 4.x yet.

Also, switch to Godot 4.1. We may not want to merge this until pcen has also signed-off on 4.1.

pcen commented 11 months ago

tested out 4.1 and everything looks good to me

WildWeazel commented 11 months ago

Is 13 for buttons intentional or a typo?

WildWeazel commented 10 months ago

bump @pcen should this go directly to godot4 or into your staging branch?

pcen commented 10 months ago

bump @pcen should this go directly to godot4 or into your staging branch?

I've been hesitant to merge anything into godot4 because I really want to avoid merge conflicts with tilemaps branch, but this should be fine to merge into godot4 directly