search

C7-Game / Prototype

An early-stage, open-source 4X strategy game
https://c7-game.github.io/
MIT License
32 stars 9 forks source link

Adding river deltas. Algorithm needs to be checked #431

Closed benskywalker closed 9 months ago

benskywalker commented 9 months ago

Fix #107. Deltas seem to work

This looks good Looks good Preexisting issue? This issue is probably unrelated. Some rivers disappear at the coast. Not sure what's going on here This might be an issue.

Another success

benskywalker commented 9 months ago

I didn't mean to push this IsLake algorithm to this PR, but it should be fine. It kind of fits. It's mostly needed for #430, but hopefully these can both be added in fairly short order

pcen commented 9 months ago

This looks awesome! It would be great if you could look into rebasing onto https://github.com/C7-Game/Prototype/pull/407, since we are in the process of updating the tile rendering to use Godot's TileMap class. The logic for choosing which tiles to render deltas on / which delta texture to use should be the same, but you'd need to add some code to load the delta pcx into a tile atlas and then index into that and add it to the tilemap

benskywalker commented 9 months ago

@pcen, I've been working on that. I'm closing this PR because it's easier to just make a new branch, but I resolved the issue with rivers not showing in the tilemaps branch at all. #433