search

C83 / THP_2.0

0 stars 0 forks source link

Add Husky finished normaly #13

Closed C83 closed 6 years ago

C83 commented 6 years ago

Process

  1. node -v => ok
  2. yarn --version => yarn installed
  3. $ yarn add husky --dev
  4. Annotate add comments on the top of files. Repo here. To install : gem 'annotate' then bundle install. Using it with annotate command.
  5. Et 6. : 
    "scripts": {
"precommit": "rubocop -a && annotate",
"prepush": "rubocop -a && rpsec && annotate"  
}
  6. Add nodes_modules/* in .gitignore

Comment

The configuration looks work. Annotate, rspec and rubocop are launched when I commit or I push. But there are errors because the configuration of rubocop is in a other issue.

Test closed issues when merge done

closes: #7

C83 commented 6 years ago

Change done. I deleted too the option -a of annotate in the package.json to avoid files changes without I check it.