search

C9Glax / tranga-website

Web-Frontend for Tranga-API
GNU General Public License v3.0
17 stars 10 forks source link

Update btn fix #20

Closed db-2001 closed 10 months ago

db-2001 commented 10 months ago

Addresses #18

db-2001 commented 10 months ago

This fixes the update button but when adding a new manga (or removing one), the manga library view doesn't automatically refresh even though RefreshContent() is called. Not sure if I added it to the right spot, but will continue to debug. Either way, the new 'issue' is much less of an apparent problem than the old one (much more scary to see all your manga disappear rather than one either not show up or still be there after add/delete) so imo this could be merged in as is. If you feel that I should fix everything at once, that's understandable too, and I'll figure that out before calling this good to go.

C9Glax commented 10 months ago

Okay, here is another git-thing: As you can see, all your previous commits are also included, which are entirely unrelated. That is why you normally (and I am also guilty of this) develop new features and fixes on seperate branches. So you would fork your master branch (before any changes) git branch <newFeatureName> and then create a PR for that branch. This way you can develop multiple features at once, without breaking production.

So the way to do this now, after the fact:

  1. Checkout the master-branch before all changes (https://github.com/db-2001/tranga-website/commit/f6544e743b84ac468ef7fa22c9a1ca75eff6f361) this commit
  2. Create the new branch
  3. Re-apply the changes to this new branch
db-2001 commented 10 months ago

Gotcha, yeah that makes sense, I can do that. I was working under the assumption that the other PR would be merged in before this one so it wouldn't end up making a difference.